parser: add unimplemented nodes to AST instead of raising exceptions (fixes #88) #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, I should have checked with you first about your preference. (The squash interface is a bit awkward, which is why I thought redoing the PR from scratch would be OK.) I hope I can get this approved, because I have follow-on changes in the works to add unimplemented nodes for arrays and arithmetic expansions. This is to minimize failures over the Bash test suite, which I am using for testing other work. Currently, about 1/3rd of the 250+ tests leading to exceptions. Best, |
|
This slipped my mind, sorry! Merged, thanks again for your work. |
tomasohara
pushed a commit
to tomasohara/bashlex
that referenced
this pull request
Jun 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.