Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve irb crash issues #102

Merged
merged 3 commits into from
Aug 14, 2023
Merged

resolve irb crash issues #102

merged 3 commits into from
Aug 14, 2023

Conversation

saipraveen18
Copy link
Contributor

https://www.pivotaltracker.com/story/show/185815646

Problem Description: dry-rb/dry-logic#104
The presence of dry-logic version 1.2.0 is leading to a conflict with irb autocomplete functionality, resulting in crashes in the Rails console (rails console).Although the conflict has been addressed in dry-logic version 1.5.0, upgrading to this version is not feasible due to dependencies on event source dry gems.As a workaround, we are applying a monkey patch to the dry-logic gem to resolve the issue

Screen.Recording.2023-08-11.at.11.34.06.AM.mov

@saikumar9 saikumar9 self-requested a review August 14, 2023 13:18
Copy link
Member

@saikumar9 saikumar9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@saikumar9 saikumar9 enabled auto-merge (squash) August 14, 2023 13:21
@vkghub vkghub self-requested a review August 14, 2023 18:42
Copy link
Contributor

@vkghub vkghub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@saikumar9 saikumar9 merged commit a4f3840 into trunk Aug 14, 2023
@saikumar9 saikumar9 deleted the ticket_185815646 branch August 14, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants