Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#97] Remove variable in "vars" in favor of "defauts" #98

Merged
merged 1 commit into from
Nov 15, 2023
Merged

[#97] Remove variable in "vars" in favor of "defauts" #98

merged 1 commit into from
Nov 15, 2023

Conversation

xtianae7
Copy link
Member

@xtianae7 xtianae7 commented Nov 15, 2023 •
edited
Loading

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions
  • Remember to set idealista:develop as base branch;
  • Add "idealista/benders" as reviewer

Description of the Change

Benefits

Possible Drawbacks

Applicable Issues

Closes #97

@xtianae7 xtianae7 self-assigned this Nov 15, 2023
@xtianae7 xtianae7 linked an issue Nov 15, 2023 that may be closed by this pull request
[REFACTOR] Remove defined variable in vars directory #97
Closed
@xtianae7 xtianae7 merged commit a7743b2 into develop Nov 15, 2023
2 checks passed
@xtianae7 xtianae7 deleted the bugs/97 branch November 15, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarioNv91 MarioNv91 MarioNv91 approved these changes

@emepege emepege emepege approved these changes

@sorobon sorobon sorobon approved these changes

@jperera jperera Awaiting requested review from jperera

@dortegau dortegau Awaiting requested review from dortegau

@ommarmol ommarmol Awaiting requested review from ommarmol

@jmonterrubio jmonterrubio Awaiting requested review from jmonterrubio

@peter91 peter91 Awaiting requested review from peter91

@insalada insalada Awaiting requested review from insalada

@Plozano94 Plozano94 Awaiting requested review from Plozano94

@abernalf abernalf Awaiting requested review from abernalf

@marcelogalmor marcelogalmor Awaiting requested review from marcelogalmor

@smartinsempere smartinsempere Awaiting requested review from smartinsempere

@LidiaSeldas LidiaSeldas Awaiting requested review from LidiaSeldas

@blalop blalop Awaiting requested review from blalop

Assignees

@xtianae7 xtianae7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[REFACTOR] Remove defined variable in vars directory
4 participants
@xtianae7 @sorobon @emepege @MarioNv91