Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove size from maki urls #119

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Remove size from maki urls #119

merged 1 commit into from
Nov 13, 2023

Conversation

Cj-Malone
Copy link
Contributor

I'm a little lost, but I think I've found the right place.

This all started with a 404. Specifically id-tagging-schema references https://cdn.jsdelivr.net/gh/mapbox/maki/icons/toll-15.svg. Interestingly https://cdn.jsdelivr.net/gh/mapbox/maki/icons/toll.svg works. I checked a few other maki urls and the seem to work with both url formats, the images look the same to me, but aren't byte for byte the same.
eg https://cdn.jsdelivr.net/gh/mapbox/maki/icons/shop-15.svg vs https://cdn.jsdelivr.net/gh/mapbox/maki/icons/shop.svg.

I've found my maki-toll, but no 15. Time to head up a level, and here we are.

But why are most of the 15s working?

It seems maki deprecated the 15 and 11 sizes in v7. The new icons only work on https://cdn.jsdelivr.net/gh/mapbox/maki/icons/animal-shelter.svg, not https://cdn.jsdelivr.net/gh/mapbox/maki/icons/animal-shelter-15.svg. My guess is the CDN still has old files on the old urls, with new files on the new urls.

So no icons from here will have any changes since pre v7, and new icons 404.

@bhousel
Copy link
Contributor

bhousel commented Sep 27, 2023

JSDelivr CDN can support different kinds of links.

  • links like /gh/project go directly to the project's GitHub
  • links like /npm/project@version go to a stable published version of that project

People should probably be using the /npm links instead of the /gh links for stable URLs.

@Cj-Malone
Copy link
Contributor Author

And a specific version via github https://cdn.jsdelivr.net/gh/mapbox/maki@v8.0.0/icons/animal-shelter.svg. schema-builder would need to start tracking releases though.

@Cj-Malone
Copy link
Contributor Author

Ping @tyrasd

@tyrasd tyrasd merged commit 6c23fd6 into ideditor:main Nov 13, 2023
1 check passed
@Cj-Malone Cj-Malone deleted the patch-1 branch November 13, 2023 14:06
@Cj-Malone
Copy link
Contributor Author

Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants