Skip to content

Commit

Permalink
Discussion results
Browse files Browse the repository at this point in the history
  • Loading branch information
AndriianChestnykh committed Nov 26, 2024
1 parent bf71699 commit 74b24a1
Showing 1 changed file with 30 additions and 2 deletions.
32 changes: 30 additions & 2 deletions contracts/verifiers/UniversalVerifierMultiQuery.sol
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ contract UniversalVerifierMultiQuery is Ownable2StepUpgradeable {
struct Request {
string metadata;
IRequestValidator validator;
bytes data;
bytes params;
}

/**
Expand All @@ -33,9 +33,37 @@ contract UniversalVerifierMultiQuery is Ownable2StepUpgradeable {
struct MultiQuery {
uint256 multiQueryId;
uint256[] requestIds;
string[] linkedOutputParamsNames; // is Output params names linked between requests
string[] linkedResponseFields; // is Output params names linked between requests
}

//TODO ___start___

// [1, 2]

Check failure on line 41 in contracts/verifiers/UniversalVerifierMultiQuery.sol

View workflow job for this annotation

GitHub Actions / solhint

Insert ····
// ["linkID","linkID"]

Check failure on line 42 in contracts/verifiers/UniversalVerifierMultiQuery.sol

View workflow job for this annotation

GitHub Actions / solhint

Insert ····
//

Check failure on line 43 in contracts/verifiers/UniversalVerifierMultiQuery.sol

View workflow job for this annotation

GitHub Actions / solhint

Insert ····
// [1, 3, 4]

Check failure on line 44 in contracts/verifiers/UniversalVerifierMultiQuery.sol

View workflow job for this annotation

GitHub Actions / solhint

Insert ····
// ["issuerID","issuerID","issuerID"]

Check failure on line 45 in contracts/verifiers/UniversalVerifierMultiQuery.sol

View workflow job for this annotation

GitHub Actions / solhint

Insert ····
//

Check failure on line 46 in contracts/verifiers/UniversalVerifierMultiQuery.sol

View workflow job for this annotation

GitHub Actions / solhint

Insert ····
// struct SignalRequestTuple {

Check failure on line 47 in contracts/verifiers/UniversalVerifierMultiQuery.sol

View workflow job for this annotation

GitHub Actions / solhint

Insert ····
// uint256 requestId;

Check failure on line 48 in contracts/verifiers/UniversalVerifierMultiQuery.sol

View workflow job for this annotation

GitHub Actions / solhint

Insert ····
// string signalName;

Check failure on line 49 in contracts/verifiers/UniversalVerifierMultiQuery.sol

View workflow job for this annotation

GitHub Actions / solhint

Insert ····
// }

Check failure on line 50 in contracts/verifiers/UniversalVerifierMultiQuery.sol

View workflow job for this annotation

GitHub Actions / solhint

Insert ····
//
// function setMultiRequest(
// uint256 multiRequestID, // "id": "f8aee09d-f592-4fcc-8d2a-8938aa26676c",
// string conditionString, // (1 || 2) && 3 && (100 || 101 || 102) // TODO consider replacing with structure
// SignalRequestTuple[][] memory linkedSignals // is Signal name too specific and should be replaced by Property or something
// // [
// // [{userID, 1}, {userID, 2}, {userID, 3}, {identity, 100}, {id, 101}, {user, 102}],
// // [{linkID, 1}, {linkID, 2}, {linkID, 3}]
// // ]
// // is this logic flexible enough? Though it might not be a problem for the first version
// // Maybe, operatorOutput = "something" is what we need as well???
// ) public {}

//TODO ___end___


/// @custom:storage-location erc7201:iden3.storage.UniversalVerifierMultiQuery
struct UniversalVerifierMultiQueryStorage {
mapping(address user => mapping(uint256 requestId => VerifierLib.Proof)) _proofs;
Expand Down

0 comments on commit 74b24a1

Please sign in to comment.