Support for wtns calc and prover options #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OBrezhniev
changed the title
Kolezhniuk
requested changes
Sep 3, 2024
…ough to 'wtns_calculate' (#519) * chore: add 'options' parameter to 'groth16FullProve', and pass it through to 'wtns_calculate' * options -> wtnsCalcOptions * also add wtnsCalcOptions argument to plonk_full_prove and fflonk_full_prove
Kolezhniuk
previously approved these changes
Sep 9, 2024
# Conflicts: # build/browser.esm.js # build/cli.cjs # build/main.cjs # build/snarkjs.js # build/snarkjs.min.js
Kolezhniuk
previously approved these changes
Sep 10, 2024
|
hey @Kolezhniuk @OBrezhniev 👋 checking in on this here, are we good to merge here? this change would be super helpful for our app, which needs the memorySize option to ensure proving doesn't crash on mobile browsers :) |
|
Yes, I hope a final review and release would happen next week. |
* Trying to fix puppeteer * Disable the sandbox to run in GHA
Kolezhniuk
previously approved these changes
Oct 16, 2024
* Allow passing prover options. First one is singleThread param for curve threadManager. * Verify proofs for both multithreaded and singlethreaded generation
OBrezhniev
changed the title
Kolezhniuk
approved these changes
Oct 16, 2024
|
thanks for the review @Kolezhniuk -- excited for the release! |
|
Hi @rrrliu , it's merged and released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support passing witness calc & prover options:
memorySizeoption to witness calcsingleTreadoption to proverOther updates: