fix(event/select): prevent scrolling when context menu opened #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idiotWu
force-pushed
the
fix-contextmenu
branch
from
e13f595 to
dd0d008
Compare
sadeghbarati
approved these changes
Aug 2, 2022
idiotWu
force-pushed
the
fix-contextmenu
branch
4 times, most recently
from
88de550 to
0776daf
Compare
idiotWu
force-pushed
the
fix-contextmenu
branch
from
0776daf to
8d315d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #489
Description
This PR fixes the bug that drag-scrolling occurs after users right-click on the page and open the context menu (i.e.
contextmenuevent fires).Types of changes