fix: define options.passive
as enumerable for compatibility
#520
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #519
CC @ajiho
Description
In the
default-passive-event
package, they copy the original event listener options usingObject.assign({}, options)
. However, since we define theoptions.passive
as non-enumerable property, this property will not be accessed in their monkey patch, and as a result, our code will assume that the browser does not support passive events according to the following detection procedure:smooth-scrollbar/src/utils/event-hub.ts
Lines 17 to 38 in 02a0d81
This modification defines
options.passive
asenumerable
to ensure compatibility with thedefault-passive-event
package.Types of changes