Feature/add example feature to custom #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustiflow/src/flows/custom_flow.rs
Outdated
| @@ -39,36 +56,41 @@ impl Flow for CustomFlow { | |||
| ts_date, | |||
| ), | |||
| // Add here the initialization of the additional features. | |||
| inter_arrival_time_total: 0.0, | |||
| last_timestamp: Some(ts_date), | |||
There was a problem hiding this comment.
Can we not reuse last timestamp of BasicFlow?
There was a problem hiding this comment.
Jup indeed, I will fix that!
mielverkerken
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an example feature to the custom flow that represents the total inter arrival between the first 10 packets in both ingress and egress direction.
Also formatted the duration print to 4 numbers behind the comma.