Fixes #1448, Fix cli and pkg options #3071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfdm
changed the title
|
i may want to rewrite that commit message before it gets merged... |
|
So this failed due to the options merging code not taking into account the |
Fixes #1448, #499. When building idris packages only preapproved command line options (if specified) will be merged into the options list from the iPKG file. These allowed options are placed at the head of the options list. The allowed options are: + Logging levels and categories + Default total, default partial + Warn partial + Warn reach + Location of IBC subdir + Location of import dir. Idris also reports an error if non-approved options are specified. This error message details the offending flags.
jfdm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building packages a preapproved command line options (if
specified) will be merged into the options list generated from the
iPKG file. The allowed options are placed at the head of the options
list such that they. The allowed options are:
Idris also reports an error if invalid command lines options are
specified when used to override package specified options. This error
message detaisl the offending flag.