Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Separate pages for tutorials and example gallery #521

Merged

Conversation

a-nozeret
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Docs update / feature: Separate pages for tutorials and example gallery.

  • What is the current behavior? (You can also link to an open issue here)
    Resolve issue Separate pages for tutorials and example gallery.  #516

  • What is the new behavior (if this is a feature change)?
    Idyll Tutorials

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    /

  • Other information:
    /

Note: @mathisonian let me know if the order of tabs navigation should change or whether some text is needed before the gallery section.

@mathisonian
Copy link
Member

Awesome! Thanks for this @a-nozeret.

I'll test locally and respond to your note above shortly

@mathisonian
Copy link
Member

This looks great - thanks again @a-nozeret!

I may add some text and additional structure to the tutorials page, but its already a big improvement. Merging and will deploy to idyll-lang.org in a minute.

@mathisonian mathisonian merged commit dd5b77b into idyll-lang:master May 31, 2019
@mathisonian
Copy link
Member

Per our policy, since you've made a substantive PR, I've sent you an invite to join the Idyll organization. This gives you the ability to submit PRs branched directly off of this repo instead of forking, which can make collaborating easier, and enables some additional privileges on issues, etc.

@a-nozeret
Copy link
Contributor Author

great! thank you @mathisonian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants