Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Exclamation mark removes paragraph break #604

Merged
merged 2 commits into from
Jan 7, 2020
Merged

fix: Exclamation mark removes paragraph break #604

merged 2 commits into from
Jan 7, 2020

Conversation

RakeshUP
Copy link
Member

@RakeshUP RakeshUP commented Jan 1, 2020

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Bug fix

  • What is the current behavior? (You can also link to an open issue here)
    Exclamation mark at end of paragraph removes paragraph break

  • What is the new behavior (if this is a feature change)?
    Symbols like *, !, _, `, numbers at end of a paragraph won't merge the following paragraph with itself

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Other information:
    Resolves Exclamation mark at the end of a paragraph removes paragraph break #542

@RakeshUP
Copy link
Member Author

RakeshUP commented Jan 1, 2020

Behaviour before:
Screenshot 2020-01-01 12 22 16

Behaviour after fix:
Screenshot 2020-01-01 12 22 11

@mathisonian
Copy link
Member

looks great @RakeshUP 💥 that diff 🔍

@mathisonian mathisonian merged commit fcab352 into idyll-lang:master Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exclamation mark at the end of a paragraph removes paragraph break
2 participants