more words to the abstract and intro section #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #2 Signed-off-by: Thomas Fossati <thomas.fossati@arm.com>
thomas-fossati
requested review from
hannestschofenig,
nedmsmith and
henkbirkholz
|
/cc @ionut-arm |
nedmsmith
reviewed
Oct 11, 2022
| messages ({{Section 8 of -rats-arch}}). | ||
| messages that aim to achieve the goals stated above. | ||
|
|
||
| These encapsulation formats are designed to be: |
There was a problem hiding this comment.
Wording should say "there are two formats" rather than "designed to have two formats"
There was a problem hiding this comment.
I don't understand the editorial suggestion. It doesn't seem to apply to L83.
There was a problem hiding this comment.
Sounds like the suggested change would be along the lines of
Suggested change
| These encapsulation formats are designed to be: | |
| There are two encapsulation formats available: |
There was a problem hiding this comment.
yes, but that doesn't work with what follows: the bulleted list describes the design criteria of the encaps, not the encaps themselves.
There was a problem hiding this comment.
closing this and merging.
hannestschofenig
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2
Signed-off-by: Thomas Fossati thomas.fossati@arm.com