Extend the error space for reset codes to 32 bits #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasilvv
requested review from
martinthomson,
aboba,
ekinnear,
DavidSchinazi and
afrind
| {{fig-remap-errors}}. | ||
| application errors for streams are limited to an unsigned 32-bit integer, | ||
| assuming values between 0x00000000 and 0xffffffff. WebTransport | ||
| implementations SHALL remap those error codes into an error range where |
There was a problem hiding this comment.
This is not really normative. Maybe better: error codes are remapped …
DavidSchinazi
approved these changes
Apr 17, 2023
marten-seemann
approved these changes
Apr 18, 2023
There was a problem hiding this comment.
I made the change in webtransport-go (quic-go/webtransport-go#74) and it looks like the math is correct.
ekinnear
approved these changes
Apr 18, 2023
afrind
approved these changes
Apr 18, 2023
vasilvv
added a commit
to vasilvv/web-transport
that referenced
this pull request
May 9, 2023
See ietf-wg-webtrans/draft-ietf-webtrans-http3#115 for the corresponding protocol change.
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 18, 2023
The latest version of WebTransport protocol uses 32-bit unsigned integer for streamErrorCode [1, 2, 3]. [1] ietf-wg-webtrans/draft-ietf-webtrans-http3#115 [2] w3c/webtransport#509 [3] w3c/webtransport#527 Bug: 1465282 Change-Id: I3a3cf9936e09ea2a0b6bb01df18ffd1d9fb287bc
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 18, 2023
The latest version of WebTransport protocol uses 32-bit unsigned integer for streamErrorCode [1, 2, 3]. [1] ietf-wg-webtrans/draft-ietf-webtrans-http3#115 [2] w3c/webtransport#509 [3] w3c/webtransport#527 Bug: 1465282 Change-Id: I3a3cf9936e09ea2a0b6bb01df18ffd1d9fb287bc
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 19, 2023
The latest version of WebTransport protocol uses 32-bit unsigned integer for streamErrorCode [1, 2, 3]. [1] ietf-wg-webtrans/draft-ietf-webtrans-http3#115 [2] w3c/webtransport#509 [3] w3c/webtransport#527 Bug: 1465282 Change-Id: I3a3cf9936e09ea2a0b6bb01df18ffd1d9fb287bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4693162 Reviewed-by: Adam Rice <ricea@chromium.org> Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/main@{#1172268}
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Jul 19, 2023
The latest version of WebTransport protocol uses 32-bit unsigned integer for streamErrorCode [1, 2, 3]. [1] ietf-wg-webtrans/draft-ietf-webtrans-http3#115 [2] w3c/webtransport#509 [3] w3c/webtransport#527 Bug: 1465282 Change-Id: I3a3cf9936e09ea2a0b6bb01df18ffd1d9fb287bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4693162 Reviewed-by: Adam Rice <ricea@chromium.org> Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/main@{#1172268}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 19, 2023
The latest version of WebTransport protocol uses 32-bit unsigned integer for streamErrorCode [1, 2, 3]. [1] ietf-wg-webtrans/draft-ietf-webtrans-http3#115 [2] w3c/webtransport#509 [3] w3c/webtransport#527 Bug: 1465282 Change-Id: I3a3cf9936e09ea2a0b6bb01df18ffd1d9fb287bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4693162 Reviewed-by: Adam Rice <ricea@chromium.org> Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/main@{#1172268}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jul 22, 2023
…32-bit long, a=testonly Automatic update from web-platform-tests [webtranport] Update streamErrorCode to 32-bit long The latest version of WebTransport protocol uses 32-bit unsigned integer for streamErrorCode [1, 2, 3]. [1] ietf-wg-webtrans/draft-ietf-webtrans-http3#115 [2] w3c/webtransport#509 [3] w3c/webtransport#527 Bug: 1465282 Change-Id: I3a3cf9936e09ea2a0b6bb01df18ffd1d9fb287bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4693162 Reviewed-by: Adam Rice <ricea@chromium.org> Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/main@{#1172268} -- wpt-commits: 7bb3ac14eace21c9ab305ee91e86fc1dba813a61 wpt-pr: 41085
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Jul 24, 2023
…32-bit long, a=testonly Automatic update from web-platform-tests [webtranport] Update streamErrorCode to 32-bit long The latest version of WebTransport protocol uses 32-bit unsigned integer for streamErrorCode [1, 2, 3]. [1] ietf-wg-webtrans/draft-ietf-webtrans-http3#115 [2] w3c/webtransport#509 [3] w3c/webtransport#527 Bug: 1465282 Change-Id: I3a3cf9936e09ea2a0b6bb01df18ffd1d9fb287bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4693162 Reviewed-by: Adam Rice <riceachromium.org> Reviewed-by: Takashi Toyoshima <toyoshimchromium.org> Commit-Queue: Kenichi Ishibashi <bashichromium.org> Cr-Commit-Position: refs/heads/main{#1172268} -- wpt-commits: 7bb3ac14eace21c9ab305ee91e86fc1dba813a61 wpt-pr: 41085 UltraBlame original commit: 7d1c74f6e9f6a49649a1aacd693f8a8a09e610c9
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Jul 24, 2023
…32-bit long, a=testonly Automatic update from web-platform-tests [webtranport] Update streamErrorCode to 32-bit long The latest version of WebTransport protocol uses 32-bit unsigned integer for streamErrorCode [1, 2, 3]. [1] ietf-wg-webtrans/draft-ietf-webtrans-http3#115 [2] w3c/webtransport#509 [3] w3c/webtransport#527 Bug: 1465282 Change-Id: I3a3cf9936e09ea2a0b6bb01df18ffd1d9fb287bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4693162 Reviewed-by: Adam Rice <riceachromium.org> Reviewed-by: Takashi Toyoshima <toyoshimchromium.org> Commit-Queue: Kenichi Ishibashi <bashichromium.org> Cr-Commit-Position: refs/heads/main{#1172268} -- wpt-commits: 7bb3ac14eace21c9ab305ee91e86fc1dba813a61 wpt-pr: 41085 UltraBlame original commit: 7d1c74f6e9f6a49649a1aacd693f8a8a09e610c9
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Jul 24, 2023
…32-bit long, a=testonly Automatic update from web-platform-tests [webtranport] Update streamErrorCode to 32-bit long The latest version of WebTransport protocol uses 32-bit unsigned integer for streamErrorCode [1, 2, 3]. [1] ietf-wg-webtrans/draft-ietf-webtrans-http3#115 [2] w3c/webtransport#509 [3] w3c/webtransport#527 Bug: 1465282 Change-Id: I3a3cf9936e09ea2a0b6bb01df18ffd1d9fb287bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4693162 Reviewed-by: Adam Rice <riceachromium.org> Reviewed-by: Takashi Toyoshima <toyoshimchromium.org> Commit-Queue: Kenichi Ishibashi <bashichromium.org> Cr-Commit-Position: refs/heads/main{#1172268} -- wpt-commits: 7bb3ac14eace21c9ab305ee91e86fc1dba813a61 wpt-pr: 41085 UltraBlame original commit: 7d1c74f6e9f6a49649a1aacd693f8a8a09e610c9
ErichDonGubler
pushed a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Jul 24, 2023
…32-bit long, a=testonly Automatic update from web-platform-tests [webtranport] Update streamErrorCode to 32-bit long The latest version of WebTransport protocol uses 32-bit unsigned integer for streamErrorCode [1, 2, 3]. [1] ietf-wg-webtrans/draft-ietf-webtrans-http3#115 [2] w3c/webtransport#509 [3] w3c/webtransport#527 Bug: 1465282 Change-Id: I3a3cf9936e09ea2a0b6bb01df18ffd1d9fb287bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4693162 Reviewed-by: Adam Rice <ricea@chromium.org> Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/main@{#1172268} -- wpt-commits: 7bb3ac14eace21c9ab305ee91e86fc1dba813a61 wpt-pr: 41085
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #90.