Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linux-arm64 and bump zig to 0.10.1 #22

Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open

Conversation

vandot
Copy link

@vandot vandot commented Apr 2, 2023

Zig with version 0.9.1 changed behaviour when missing Mac OSX Frameworks from warning to error as explained here
This PR adds automatic SDK installation on Linux, while on Windows it expects for SDK to be preinstalled and path to it provided with --sdk flag. SDK has a lot of symlinks and any possible solution that I tried on Windows, packing it with zip or with tar using --dereference, didn't worked. Using any combination of zip, 7z, tar, zippy.ziparchives.extractAll() and zippy.tarballs.extractAll()` failed.

Probably due what is explained in clang 15 Release notes

The -Wint-conversion warning diagnostic for implicit int <-> pointer conversions now defaults to an error in all C language modes. It may be downgraded to a warning with -Wno-error=int-conversion, or disabled entirely with -Wno-int-conversion.

Now threading test from windows|macosx to linux-amd64 fails with following error:

error: incompatible integer to pointer conversion passing 'unsigned long' to parameter of type 'pthread_t' (aka 'struct __pthread *') [-Wint-conversion]
        T1_ = pthread_join(t.sys, ((void**) NIM_NIL));
                           ^~~~~

Passing -Wno-error=int-conversion reverts its to a warning.

All Mac OSX SDKs can be found here and download should be cleaned (keep only MacOSX stuff) and hosted somewhere, maybe as a repo's release artifact.

All tests passed in my fork - https://github.com/vandot/nimxc/actions/runs/4590217179

@iffy
Copy link
Owner

iffy commented Apr 10, 2023

Thank you for all this work! It might take me a while to review it.

@vandot
Copy link
Author

vandot commented Apr 10, 2023

Most of the changes are for enabling MacOSX SDK autoinstall for Linux. Most of the commits are for trying the same for Windows 😬 (I dont have Windows so I used Github Action runners for testing 🤷‍♂️) Squashing will resolve it 🙂

@vandot
Copy link
Author

vandot commented Jun 3, 2023

@iffy any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants