-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add linux-arm64 and bump zig to 0.10.1 #22
Open
vandot
wants to merge
25
commits into
iffy:master
Choose a base branch
from
vandot:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for all this work! It might take me a while to review it. |
Most of the changes are for enabling MacOSX SDK autoinstall for Linux. Most of the commits are for trying the same for Windows 😬 (I dont have Windows so I used Github Action runners for testing 🤷♂️) Squashing will resolve it 🙂 |
@iffy any update on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zig with version
0.9.1
changed behaviour when missing Mac OSX Frameworks from warning to error as explained hereThis PR adds automatic SDK installation on Linux, while on Windows it expects for SDK to be preinstalled and path to it provided with
--sdk
flag. SDK has a lot of symlinks and any possible solution that I tried on Windows, packing it withzip
or withtar
using--dereference
, didn't worked. Using any combination ofzip
,7z
,tar
,zippy.ziparchives.extractAll() and
zippy.tarballs.extractAll()` failed.Probably due what is explained in clang 15 Release notes
Now threading test from
windows|macosx
tolinux-amd64
fails with following error:Passing
-Wno-error=int-conversion
reverts its to a warning.All Mac OSX SDKs can be found here and download should be cleaned (keep only MacOSX stuff) and hosted somewhere, maybe as a repo's release artifact.
All tests passed in my fork - https://github.com/vandot/nimxc/actions/runs/4590217179