Fix issue with tests in utils/add additional tests #2293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for opening this pull request with us! Be sure to follow our Pull Request Practices. Let us know if you have any questions on Slack. |
…ame, add tests to cover all util methods
|
Thanks for fixing this!! And adding more coverage 🎉 |
|
Thank you for merging this pull request with us! If you haven't already, in another pull request, please add yourself to our About page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In 'client/app/utils' the tests were not being run by jest due to naming convention. For fixing this i have changed the filename of the test file.
After changing the file name, have fixed the issues with the existing test file and have also added additional tests to cover all the methods defined in 'client/app/utils/index.js'
Reviewing this pull request? Check out our Code Review Practices guide if you haven't already!