-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: cosmwasm plugin #2
Conversation
Bounty referece: #56 |
…nary instead of reading them from the filesystem
…, added 2 getter functions ChainName() and ChainNamed()
Thanks for the feedback @Pantani , I've addressed most of the issues by applying .plush files, genny generator, and placeholder code. I would like to get feedback on current solution for maintaining app.go file. |
@yerasyla, thanks for the changes and efforts. I think you didn't understand the idea; you should inject the code into the existing templates we already have in the code. You can use the built-in |
…g 2 chunks of code) using ASTs
@Pantani @jeronimoalbi I have attempted to use ASTs to modify existing app.go file that was scaffolded with Ignite CLI. There is no need to maintain separate app.go now. Could you provide high level feedback on what direction I should focus to deliver the best possible Ignite app for cosmwasm integration. |
Hey @yerasyla Thanks for the great work! I'm new to ignite and i'm very interested to know how you implemented your AST-based approach for modifying the existing go files in chain. Could you give me a brief on how it works? How flexible is your approach (e.g. If some of the |
Hi @Ehsan-saradar , thank you for feedback! Provided AST based approach basically consist of:
It took me a while to figure it, and the current implementation could be heavily optimised. But if you want more insights maybe we can have a quick call and discuss ASTs. Regarding flexibility, I believe it depends on the severity of changes in file. E.g. some code injections depend on the name of expression, if the expression is renamed or deleted, it can no longer be found in AST and there will be no injection. I believe it is still flexible and with some optimisation it can handle most edge cases when it comes to change in app.go. Also this tool helped me a lot in visualising AST of the files: https://astexplorer.net/ |
Hi @yerasyla thanks for your contributions. For the bounty, could you contact us at hello@tendermint.com? Thank you! |
Hello, I have just send the mail from yerasyl.amanbek@alumni.nu.edu.kz , could you check. Thank you! |
No description provided.