Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add hermes relayer plugin #3

Merged
merged 44 commits into from
Oct 15, 2023
Merged

feat: add hermes relayer plugin #3

merged 44 commits into from
Oct 15, 2023

Conversation

Pantani
Copy link
Collaborator

@Pantani Pantani commented Sep 2, 2023

  • create the chains mars-1 and venus-1 and run

  • add the relayer plugin

ignite app add -g ($GOPATH)/src/github.com/ignite/apps/hermes
  • configure the relayer
ignite relayer hermes configure "mars-1" "http://localhost:26649" "http://localhost:9082" "venus-1" "http://localhost:26659" "http://localhost:9092"
  • start the relayer
ignite relayer hermes start "mars-1" "venus-1"

@Pantani Pantani self-assigned this Sep 2, 2023
@jeronimoalbi
Copy link
Member

Maybe as a future improvement we could use default RPC addresses, where each one could be optional though a CLI flag. When the optional flag for any of the addresses is not available we could ask the user to input the value(s) offering default ones.

@Pantani Pantani marked this pull request as ready for review September 7, 2023 20:05
.golangci.yml Outdated Show resolved Hide resolved
LICENSE Outdated Show resolved Hide resolved
@Pantani Pantani requested a review from julienrbrt September 25, 2023 13:49
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly nits. I'll test the changes locally now

go.work.sum Outdated Show resolved Hide resolved
hermes/Makefile Outdated Show resolved Hide resolved
hermes/Makefile Outdated Show resolved Hide resolved
hermes/cmd/hermes_start.go Outdated Show resolved Hide resolved
hermes/cmd/hermes_start.go Outdated Show resolved Hide resolved
Co-authored-by: Julien Robert <julien@rbrt.fr>
hermes/Makefile Outdated Show resolved Hide resolved
go.work Outdated Show resolved Hide resolved
@jeronimoalbi
Copy link
Member

Does it make sense to create a new PR to update the IBC related tutorials to use this app instead of the tsrelayer? That would make this app a CLI default one, like the network app.

@ilgooz @Pantani

@Pantani Pantani requested a review from Ehsan-saradar as a code owner October 4, 2023 11:16
Pantani and others added 2 commits October 4, 2023 13:19
Co-authored-by: Jerónimo Albi <jeronimo.albi@gmail.com>
@Pantani
Copy link
Collaborator Author

Pantani commented Oct 4, 2023

Does it make sense to create a new PR to update the IBC related tutorials to use this app instead of the tsrelayer? That would make this app a CLI default one, like the network app.

@ilgooz @Pantani

I think so, but we can only hidden the tsrelayer for now and try to see if it works in future updates, and we can have both

@Pantani Pantani requested a review from julienrbrt October 13, 2023 00:43
hermes/README.md Outdated Show resolved Hide resolved
hermes/README.md Outdated Show resolved Hide resolved
Pantani and others added 2 commits October 13, 2023 14:59
Co-authored-by: Jerónimo Albi <jeronimo.albi@gmail.com>
Co-authored-by: Jerónimo Albi <jeronimo.albi@gmail.com>
@Pantani Pantani merged commit 5f5df12 into main Oct 15, 2023
@Pantani Pantani deleted the feat/add-hermes-plugin branch October 15, 2023 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants