Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: cosmwasm official app #60

Merged
merged 30 commits into from
Feb 23, 2024
Merged

feat: cosmwasm official app #60

merged 30 commits into from
Feb 23, 2024

Conversation

Pantani
Copy link
Collaborator

@Pantani Pantani commented Feb 9, 2024

No description provided.

Developer Experience team at Ignite and others added 2 commits February 7, 2024 22:12
@Pantani Pantani self-assigned this Feb 9, 2024
@Pantani Pantani marked this pull request as ready for review February 10, 2024 08:17
Ehsan-saradar
Ehsan-saradar reviewed Feb 12, 2024
View reviewed changes
official/wasm/integration/app_test.go Outdated Show resolved Hide resolved
official/wasm/pkg/goanalysis/goanalysis.go Outdated Show resolved Hide resolved
official/wasm/cmd/cmd.go Outdated Show resolved Hide resolved
@toschdev
Copy link
Contributor

Please don't use the "official" directory. It should just be github.com/ignite/apps/wasm - not github.com/ignite/apps/official/wasm

Ehsan-saradar
Ehsan-saradar reviewed Feb 15, 2024
View reviewed changes
official/wasm/cmd/cmd.go Outdated Show resolved Hide resolved
official/wasm/cmd/cmd.go Outdated Show resolved Hide resolved
official/wasm/cmd/debug/main.go Outdated Show resolved Hide resolved
jeronimoalbi
jeronimoalbi reviewed Feb 16, 2024
View reviewed changes
official/wasm/go.mod Outdated Show resolved Hide resolved
@jeronimoalbi
Copy link
Member

Successfully tested a newly scaffolded chain and a contract. Great work @Pantani 🥇

Pantani and others added 11 commits February 16, 2024 15:37
@Pantani @jeronimoalbi
Update official/wasm/pkg/goanalysis/goanalysis.go
0cb7c95 
Co-authored-by: Jerónimo Albi <jeronimo.albi@gmail.com>
@Pantani @jeronimoalbi
Update official/wasm/services/scaffolder/wasm.go
32c4c05 
Co-authored-by: Jerónimo Albi <jeronimo.albi@gmail.com>
@Pantani @jeronimoalbi
Update official/wasm/cmd/config.go
923a06f 
Co-authored-by: Jerónimo Albi <jeronimo.albi@gmail.com>
@Pantani @jeronimoalbi
Update official/wasm/main.go
e36ac42 
Co-authored-by: Jerónimo Albi <jeronimo.albi@gmail.com>
@Pantani @jeronimoalbi
Update official/wasm/go.mod
b4642c2 
Co-authored-by: Jerónimo Albi <jeronimo.albi@gmail.com>
@Pantani @jeronimoalbi
Update official/wasm/pkg/config/config_test.go
c67b018 
Co-authored-by: Jerónimo Albi <jeronimo.albi@gmail.com>
Merge remote-tracking branch 'origin/main' into feat/cosmwasm-officia…
7f55ba0 
…l-app
usa github.com/ignite/apps/wasm namespace instead only wasm
50ea09d
apply some comments suggestions
6358fe2
Merge remote-tracking branch 'origin/main' into feat/cosmwasm-officia…
6d2795e 
…l-app
run go mod tidy
518ecf2
This was referenced Feb 21, 2024
Closed
Closed
jeronimoalbi
jeronimoalbi previously approved these changes Feb 22, 2024
View reviewed changes
Copy link
Member

@jeronimoalbi jeronimoalbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Pantani Pantani requested review from Ehsan-saradar and removed request for Ehsan-saradar February 22, 2024 20:22
@Pantani Pantani enabled auto-merge (squash) February 23, 2024 11:51
@Pantani Pantani removed the request for review from Ehsan-saradar February 23, 2024 11:51
Pantani
Pantani commented Feb 23, 2024
View reviewed changes
wasm/README.md Show resolved Hide resolved
@Pantani Pantani merged commit 3c71122 into main Feb 23, 2024
12 checks passed
@Pantani Pantani deleted the feat/cosmwasm-official-app branch February 23, 2024 14:45
@salmad3 salmad3 mentioned this pull request May 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ehsan-saradar Ehsan-saradar Ehsan-saradar left review comments

@jeronimoalbi jeronimoalbi jeronimoalbi approved these changes

@ilgooz ilgooz Awaiting requested review from ilgooz ilgooz is a code owner

@julienrbrt julienrbrt Awaiting requested review from julienrbrt julienrbrt is a code owner

Assignees

@Pantani Pantani

Labels
None yet
Projects
Ignite CLI Masterboard
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Pantani @toschdev @jeronimoalbi @Ehsan-saradar