Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: set positional args for delete commands and scaffolded autocli config #3822

Merged
merged 9 commits into from
Dec 12, 2023
Merged

feat: set positional args for delete commands and scaffolded autocli config #3822

merged 9 commits into from
Dec 12, 2023

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Dec 6, 2023 •
edited
Loading

Closes: #3823

  • Improve command description for map/list/singleton txs
  • Scaffold delete command argument as a positional argument instead of flag.

@julienrbrt julienrbrt marked this pull request as draft December 6, 2023 16:40
@julienrbrt julienrbrt changed the title feat: set positional args for delete commands and improve command helpers feat: set positional args for delete commands and scaffolded autocli config Dec 6, 2023
@julienrbrt julienrbrt marked this pull request as ready for review December 6, 2023 19:41
jeronimoalbi
jeronimoalbi previously approved these changes Dec 7, 2023
View reviewed changes
@codecov Codecov
Copy link

codecov bot commented Dec 12, 2023 •
edited
Loading

Codecov Report

Merging #3822 (6b07b51) into main (a40ccc8) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3822      +/-   ##
==========================================
- Coverage   24.33%   24.31%   -0.03%     
==========================================
  Files         292      292              
  Lines       24517    24532      +15     
==========================================
- Hits         5966     5964       -2     
- Misses      18015    18031      +16     
- Partials      536      537       +1
Files Coverage Δ
ignite/templates/typed/singleton/singleton.go 0.00% <0.00%> (ø)
ignite/templates/typed/list/list.go 0.00% <0.00%> (ø)
ignite/templates/typed/map/map.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

Pantani
Pantani previously approved these changes Dec 12, 2023
View reviewed changes
@julienrbrt julienrbrt merged commit c8c9f8e into main Dec 12, 2023
43 checks passed
@julienrbrt julienrbrt deleted the julien/autocli branch December 12, 2023 22:13
@julienrbrt julienrbrt mentioned this pull request Dec 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pantani Pantani Pantani approved these changes

@ilgooz ilgooz Awaiting requested review from ilgooz ilgooz is a code owner

@Ehsan-saradar Ehsan-saradar Awaiting requested review from Ehsan-saradar

@salmad3 salmad3 Awaiting requested review from salmad3 salmad3 is a code owner

@toschdev toschdev Awaiting requested review from toschdev toschdev is a code owner

@jeronimoalbi jeronimoalbi Awaiting requested review from jeronimoalbi jeronimoalbi is a code owner

Assignees

@julienrbrt julienrbrt

Labels
component:ci CI/CD workflow and automated jobs. component:configs component:templates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve scaffolded autocli config
3 participants
@julienrbrt @jeronimoalbi @Pantani