Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Minor keplr type-checking bug #3825

Merged
merged 3 commits into from
Dec 8, 2023
Merged

fix: Minor keplr type-checking bug #3825

merged 3 commits into from
Dec 8, 2023

Conversation

clockworkgr
Copy link
Collaborator

Found this while doing some more extensive testing. coinType has been deprecated from the root keplr ChainInfo type and lives only in the Bip44 field

jeronimoalbi
jeronimoalbi previously approved these changes Dec 7, 2023
@jeronimoalbi
Copy link
Member

@clockworkgr would you add a new entry to the changelod.md?

@clockworkgr
Copy link
Collaborator Author

@clockworkgr would you add a new entry to the changelod.md?

done...mb

jeronimoalbi
jeronimoalbi previously approved these changes Dec 7, 2023
Pantani
Pantani previously approved these changes Dec 8, 2023
@Pantani Pantani dismissed stale reviews from jeronimoalbi and themself via 696a0c7 December 8, 2023 20:17
@Pantani Pantani merged commit 3a5a40d into main Dec 8, 2023
5 of 8 checks passed
@Pantani Pantani deleted the fix/minor-keplr-bug branch December 8, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants