Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gacli): fix analytics event name #3860

Merged
merged 3 commits into from
Dec 21, 2023
Merged

fix(gacli): fix analytics event name #3860

merged 3 commits into from
Dec 21, 2023

Conversation

Pantani
Copy link
Collaborator

@Pantani Pantani commented Dec 21, 2023

The event name does not allow strings with underscores

@julienrbrt julienrbrt changed the title fix: fix analytics event name fix(gacli): fix analytics event name Dec 21, 2023
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@Pantani Pantani merged commit 7d39994 into main Dec 21, 2023
44 checks passed
@Pantani Pantani deleted the fix/analytics-event-name branch December 21, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants