Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: revert refactor(templates): add all ibc commands #3866

Closed
wants to merge 1 commit into from
Closed

fix: revert refactor(templates): add all ibc commands #3866

wants to merge 1 commit into from

Conversation

Pantani
Copy link
Collaborator

@Pantani Pantani commented Dec 25, 2023

Reverts #3858

@Pantani Pantani self-assigned this Dec 25, 2023
@Pantani Pantani changed the title Revert "refactor(templates): add all ibc commands" fix: revert "refactor(templates): add all ibc commands" Dec 25, 2023
@Pantani Pantani changed the title fix: revert "refactor(templates): add all ibc commands" fix: revert refactor(templates): add all ibc commands Dec 25, 2023
@julienrbrt
Copy link
Member

julienrbrt commented Dec 25, 2023 •
edited
Loading

Curious what's the reason 😬
EDIT: found it: #3865

Imho we should remove from the map the IBC ones that shouldn't be added.

@julienrbrt
Copy link
Member

Actually, does it tries a genesis export? Because if so then the module isn't correctly wired right.

@Pantani
Copy link
Collaborator Author

Pantani commented Dec 25, 2023

Actually, does it tries a genesis export? Because if so then the module isn't correctly wired right.

ignite always runs the export genesis command when we stop the chain and throws an error because can't export the genesis

@Pantani
Copy link
Collaborator Author

Pantani commented Dec 25, 2023

Curious what's the reason 😬 EDIT: found it: #3865

Imho we should remove from the map the IBC ones that shouldn't be added.

yes, is the same issue

@julienrbrt
Copy link
Member

Okay, then there is some issue with genesis export, we should check the module wiring instead of reverting this that showed the bug.

@Pantani
Copy link
Collaborator Author

Pantani commented Dec 26, 2023

Okay, then there is some issue with genesis export, we should check the module wiring instead of reverting this that showed the bug.

sure! IMHO we can revert now and launch the v28.2 without this bug and find a better solution for the next version

@TraderWithPython
Copy link

Okay, then there is some issue with genesis export, we should check the module wiring instead of reverting this that showed the bug.

sure! IMHO we can revert now and launch the v28.2 without this bug and find a better solution for the next version

i wanna know when the v28.2 will be released.

julienrbrt
julienrbrt reviewed Dec 26, 2023
View reviewed changes
changelog.md
@@ -22,7 +22,7 @@
- [#3827](https://github.com/ignite/cli/pull/3827) Change ignite apps to be able to run in any directory
- [#3831](https://github.com/ignite/cli/pull/3831) Correct ignite app gRPC server stop memory issue
- [#3825](https://github.com/ignite/cli/pull/3825) Fix a minor Keplr type-checking bug in TS client
- [#3836](https://github.com/ignite/cli/pull/3836), [#3858](https://github.com/ignite/cli/pull/3858) Add missing IBC commands for scaffolded chain
- [#3836](https://github.com/ignite/cli/pull/3836) Add missing IBC commands for scaffolded chain
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, should be under another changelog, under unreleased

@julienrbrt
Copy link
Member

julienrbrt commented Dec 26, 2023 •
edited
Loading

I opened a fix here: #3867.
Turns out the module wiring was correct, but I forgot to add those modules to the basic module manager.

@julienrbrt julienrbrt closed this Dec 27, 2023
@julienrbrt julienrbrt deleted the revert-3858-julien/add-all-ibc-cmd branch March 19, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt left review comments

@ilgooz ilgooz Awaiting requested review from ilgooz ilgooz is a code owner

@salmad3 salmad3 Awaiting requested review from salmad3 salmad3 is a code owner

@toschdev toschdev Awaiting requested review from toschdev toschdev is a code owner

@jeronimoalbi jeronimoalbi Awaiting requested review from jeronimoalbi jeronimoalbi is a code owner

@Ehsan-saradar Ehsan-saradar Awaiting requested review from Ehsan-saradar

Assignees

@Pantani Pantani

Labels
component:ci CI/CD workflow and automated jobs. component:configs component:templates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Pantani @julienrbrt @TraderWithPython