Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(services/chain): .git in parent dir #3869

Merged
merged 7 commits into from
Jan 9, 2024

Conversation

huanxiangspace
Copy link
Contributor

@huanxiangspace huanxiangspace commented Dec 27, 2023

When the directory is contained within a project, not as a lone git project, building cannot get the git info from parent directories.

@julienrbrt
Copy link
Member

Hi! Can you add a description to your PR and explain why you are targeting a release branch instead of main?

@huanxiangspace
Copy link
Contributor Author

Hi! Can you add a description to your PR and explain why you are targeting a release branch instead of main?

Because I'd like to use the 0.27 version. If you will not update the 0.27 version, I will change the target branch to main.

@huanxiangspace huanxiangspace changed the base branch from release/v0.27.2 to main January 8, 2024 13:36
@github-actions github-actions bot added component:ci CI/CD workflow and automated jobs. component:configs component:packages labels Jan 8, 2024
@julienrbrt
Copy link
Member

Thanks! Can you add a changelog?

changelog.md Outdated Show resolved Hide resolved
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK.

@julienrbrt julienrbrt enabled auto-merge (squash) January 8, 2024 20:01
@julienrbrt julienrbrt merged commit 6cc13bc into ignite:main Jan 9, 2024
43 checks passed
@huanxiangspace huanxiangspace deleted the release/v0.27.2 branch February 29, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants