feat(cmd): make some cmd pkg functions public
#3985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ath` to `xfilepath`
Pantani
requested review from
ilgooz,
jeronimoalbi and
julienrbrt
as code owners
github-actions
bot
added
component:ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3985 +/- ##
=======================================
Coverage 25.70% 25.70%
=======================================
Files 307 307
Lines 25727 25730 +3
=======================================
+ Hits 6612 6614 +2
+ Misses 18540 18539 -1
- Partials 575 577 +2
|
Pantani
changed the title
sourceModificationToString function to xgenny and relativePath function to xfilepathcmd to be reusable
Pantani
changed the title
cmd to be reusablecmd pkg functions public
jeronimoalbi
previously approved these changes
Feb 23, 2024
Pantani
dismissed stale reviews from julienrbrt and jeronimoalbi
via
8916aac
It will be nice because we can reuse these methods in the WASM app. |
julienrbrt
approved these changes
Feb 23, 2024
mergify bot
pushed a commit
that referenced
this pull request
Feb 23, 2024
* move `sourceModificationToString` function to `xgenny` and `relativePath` to `xfilepath` * move `newChainWithHomeFlags` to the services package to be reusable * add changelog * rename the method `chain.NewChainWithHomeFlags` to `chain.NewWithHomeFlags` --------- Co-authored-by: Pantani <Pantani> (cherry picked from commit a27cd72) # Conflicts: # ignite/cmd/chain_lint.go # ignite/cmd/scaffold_configs.go # ignite/cmd/scaffold_params.go
julienrbrt
pushed a commit
that referenced
this pull request
Feb 27, 2024
Merged
julienrbrt
pushed a commit
that referenced
this pull request
May 29, 2024
* move `sourceModificationToString` function to `xgenny` and `relativePath` to `xfilepath` * move `newChainWithHomeFlags` to the services package to be reusable * add changelog * rename the method `chain.NewChainWithHomeFlags` to `chain.NewWithHomeFlags` --------- Co-authored-by: Pantani <Pantani>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #3982
close #3981
Description
sourceModificationToStringfunction toxgennypkg;relativePathfunction toxfilepathpkg;newChainWithHomeFlagsfunction toservicespkg;