Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve buf rate limit #4133

Merged
merged 32 commits into from
May 21, 2024
Merged

feat: improve buf rate limit #4133

merged 32 commits into from
May 21, 2024

Conversation

Pantani
Copy link
Collaborator

@Pantani Pantani commented May 13, 2024

Description

  • Remove third_party_paths from the chain config.
  • Decrease the Buf. Build requests by grouping the requests into only one using the --path for the generate command.
  • Create an option to run the proto files one by one so we can skip the workspace for the third-party modules, like the swagger file generation.
  • Create a cache for the buf file, increasing the Ignite run speed.

@Pantani Pantani self-assigned this May 13, 2024
@Pantani Pantani changed the title feat: improve buf rate feat: improve buf rate limit May 13, 2024
@Pantani Pantani marked this pull request as ready for review May 13, 2024 17:26
jeronimoalbi
jeronimoalbi previously approved these changes May 17, 2024
@Pantani Pantani disabled auto-merge May 21, 2024 17:59
@Pantani Pantani enabled auto-merge (squash) May 21, 2024 17:59
@Pantani Pantani merged commit 0b41262 into main May 21, 2024
48 checks passed
@Pantani Pantani deleted the feat/improve-buf-rate branch May 21, 2024 18:04
julienrbrt pushed a commit that referenced this pull request May 29, 2024
* draft improvements

* use --path flag mutilple times

* remove `Build.Proto.ThirdPartyPaths` from the config

* add logic for run buf by folder or by file

* update cosmos-sdk

* fix exclude files for swagger

* fix buf cache

* add changelog

* update buf deps

* fix unit test

* fix wrong proto go path

* clear buf cache

* fix doctor tests and remove `third_party_paths` from the docs

* improve Test_extractRootModulePath test cases

* Update ignite/pkg/cosmosbuf/cache.go

Co-authored-by: Jerónimo Albi <jeronimo.albi@tendermint.com>

* fix changelog.md

* improve cache logic

* create a dircache pkg

* add comments

* rename methods `CopyCache` to `CopyTo` and `SaveCache` to `Save`

---------

Co-authored-by: Pantani <Pantani>
Co-authored-by: Jerónimo Albi <jeronimo.albi@tendermint.com>
@julienrbrt
Copy link
Member

@Mergifyio backport release/v28.x.y

Copy link
Contributor

mergify bot commented Jun 21, 2024

backport release/v28.x.y

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jun 21, 2024
* draft improvements

* use --path flag mutilple times

* remove `Build.Proto.ThirdPartyPaths` from the config

* add logic for run buf by folder or by file

* update cosmos-sdk

* fix exclude files for swagger

* fix buf cache

* add changelog

* update buf deps

* fix unit test

* fix wrong proto go path

* clear buf cache

* fix doctor tests and remove `third_party_paths` from the docs

* improve Test_extractRootModulePath test cases

* Update ignite/pkg/cosmosbuf/cache.go

Co-authored-by: Jerónimo Albi <jeronimo.albi@tendermint.com>

* fix changelog.md

* improve cache logic

* create a dircache pkg

* add comments

* rename methods `CopyCache` to `CopyTo` and `SaveCache` to `Save`

---------

Co-authored-by: Pantani <Pantani>
Co-authored-by: Jerónimo Albi <jeronimo.albi@tendermint.com>
(cherry picked from commit 0b41262)

# Conflicts:
#	ignite/cmd/cmd.go
#	ignite/config/chain/base/config.go
#	ignite/config/chain/v1/testdata/config.yaml
#	ignite/config/chain/v1/testdata/config2.yaml
#	ignite/internal/analytics/analytics.go
#	ignite/pkg/cosmosbuf/buf.go
#	ignite/pkg/cosmosgen/generate_go.go
#	ignite/pkg/cosmosgen/generate_openapi.go
#	integration/doctor/testdata/config-need-migrate.txt
@Pantani Pantani added backport/v28.x.y Backport to v28.x.y and removed backport/v28.x.y Backport to v28.x.y labels Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v28.x.y Backport to v28.x.y component:ci CI/CD workflow and automated jobs. component:cmd component:configs component:docs Documentation additions or improvements. component:packages component:templates type:internal type:services Service-related issues.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants