Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Capitalize the itemName #214

Merged
merged 4 commits into from
Feb 22, 2022

Conversation

mihailmarcu
Copy link
Contributor

@mihailmarcu mihailmarcu commented Feb 18, 2022

Description & Context

All requests to the blog item use camel case naming conventions and are strictly dependent on them. For now, we allow names that can start with a lowercase letter and break requests. We now convert the itemName property to start with uppercase.

How To Test

  1. Open the Data.view template;
  2. For item-name prop try using the name like item-name="modelName" or item-name="ModelName";
  3. In both cases the module should work;

Linked issue

Closes #201

@mihailmarcu mihailmarcu added the enhancement Improvement over existing feature label Feb 18, 2022
@mihailmarcu mihailmarcu self-assigned this Feb 18, 2022
…rop_case_sensitive

# Conflicts:
#	packages/vue/src/components/SpCrud/SpCrud.vue
@mihailmarcu mihailmarcu changed the title 201: Capitalize the itemName fix: Capitalize the itemName Feb 22, 2022
@mihailmarcu mihailmarcu merged commit f7649e0 into develop Feb 22, 2022
@mihailmarcu mihailmarcu deleted the feature/201_crud_prop_case_sensitive branch February 23, 2022 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement over existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix:item-name only works if capitalised (crud)
2 participants