Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OF-1838 XEP-0157: Improve support #1468

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

mnsuccess
Copy link
Member

XEP-0157 support in Openfire should be improved upon. Ideally, the admin console is used to determine what users are exposed as what kind of XEP-0157 contact.

@guusdk
Copy link
Member

guusdk commented Sep 2, 2019

Do we need a servlet for this? It's not a bad approach, but we hardly use servlets, and do everything in JSP. If there's a reason for having a servlet, I'm not against it.

@GregDThomas
Copy link
Contributor

I've used servlets in a couple of places (e.g. the new System properties page). Possibly my bad for not highlighting that at the time, but ...

I'd encourage use of servlets. It does make things far neater, IMHO. A much cleaner seperation of logic and display, less likely to get CSRF problems, etc. etc.

@deleolajide
Copy link
Member

I use both in plugins and would like to keep both options open. Slightly different tools to achieve the same purpose.

@guusdk
Copy link
Member

guusdk commented Sep 2, 2019

I agree that using servlets is generally a good idea. In this instance, I'd like to keep the code somewhat consistent.

I'd be happy to introduce Servlets, but then I'd ask you to introduce them everywhere. :)

@GregDThomas
Copy link
Contributor

I'd like to see servlets everywhere, but practically speaking I think the only way you're going to get it done is a few at a time.

@guusdk
Copy link
Member

guusdk commented Sep 2, 2019

Three years in, we're still halfway through JSTL :(

@guusdk
Copy link
Member

guusdk commented Sep 3, 2019

@mnsuccess why prefix every column name with the letter 'c'?

@mnsuccess
Copy link
Member Author

@mnsuccess why prefix every column name with the letter 'c'?
prefix c as a contact. I wanted to prefix with the word contact it seemed long then I just prefixed it with c. maybe we don't need to prefix column

@guusdk
Copy link
Member

guusdk commented Sep 3, 2019

Ah I see. It's a bit redundant as there will only be contacts in that table anyway, but hey :)

@mnsuccess
Copy link
Member Author

Should I keep using servlet ?

@guusdk
Copy link
Member

guusdk commented Jun 29, 2020

Using servlets is fine, but please stop using the letter c as the first letter of each database column name.

@akrherz
Copy link
Member

akrherz commented Aug 16, 2020

@mnsuccess Are you still working on this PR?

@mnsuccess
Copy link
Member Author

@akrherz yes I'm still working on this !!

@akrherz
Copy link
Member

akrherz commented Oct 20, 2020

Hi @mnsuccess, are you able to rebase this PR onto current master?

@Neustradamus
Copy link
Contributor

@mnsuccess: Have you progressed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants