Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gradle plugins #612

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Conversation

stokito
Copy link
Contributor

@stokito stokito commented Aug 12, 2024

The build.gradle uses a a plugin org.kordamp.gradle:clirr-gradle-plugin:0.2.2 that is very outdated. It comes from the dl.bintray.com/content/aalmiray/kordamp repo that is even not works anymore.
I tried to repair it and upgrade to latest version but that was too complicated for me. Anyway, the plugin currently is disabled. So instead I removed it for now and if anyone can restore it and enable then you may check history.
Check it's documentation https://plugins.gradle.org/plugin/org.kordamp.gradle.clirr

The biz.aQute.bnd.builder plugin was added in an old Gradle style so I migrated it to the new and declared in the plugins. I also updated it from v6.0.0 to v.6.4.0.

The jcenter() repo doesn't exists anymore and I removed it. The https://plugins.gradle.org/m2/ replaced with gradlePluginPortal().

@stokito
Copy link
Contributor Author

stokito commented Aug 12, 2024

since the repo hasn't issues tab I'll report the problem here

Compilation failed because the org/jivesoftware/smack/android/AndroidSmackInitializer.java:41 uses a deprecated StrictHostnameVerifier.
The class should be replaced with the DefaultHostnameVerifier.
But the httpclient library that is used in a project is actually older then the StrictHostnameVerifier was deprecated so I'm confused from where the Gradle get the deprecation notice.

To temporary fix the problem I had to disable compilation failing in warning and removed from the build.gradle the '-Werror', line. Not sure how to fix this properly.

In the 7562528 package-info.java files were replaced with symliks. I made a clone of the repo and instead of symlinks I got them as files with ../../../../../../../../../smack-core/src/main/java/org/jivesoftware/smack/util/stringencoder/package-info.java as a content. Probably on Windows they were committed as files.

I made a temp commit for myself to pass the compilation where I replaced the content of files with a package statements c2212ef

But we should ether restore the symlinks or just get pack to plain files (it's ok if they will be duplicated)

@Flowdalic
Copy link
Member

Thanks for your contribution.

I always hoped to re-enabled clirr, since the functionality it provided was great. But it seems about time that we drop it.

Also kudos for making the changes in two commits. +1

LGTM

@stokito
Copy link
Contributor Author

stokito commented Aug 27, 2024

Thank you. Please also check my vomment about package.info.

Could you please open issues on the repo? In the Jira I don't have a permission report a bug, only in the Spark project

@Flowdalic Flowdalic added this pull request to the merge queue Sep 12, 2024
Merged via the queue into igniterealtime:master with commit 7024151 Sep 12, 2024
2 checks passed
@stokito stokito deleted the fix_gradle_plugins branch September 12, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants