[muc] MultiUserChat should have consistent API #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`org.jivesoftware.smackx.muc.MultiUserChat` has various methods that change affiliation of entities in the room. All of these work on instances of `Jid`, except for `org.jivesoftware.smackx.muc.MultiUserChat#revokeAdmin(org.jxmpp.jid.EntityJid)` (which uses `EntityJid`). The API ideally is consistent - even `grantAdmin()` uses `Jid`. `revokeAdmin()` should also use `Jid` instead of `EntityJid`. Fixes SMACK-948
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
org.jivesoftware.smackx.muc.MultiUserChathas various methods that change affiliation of entities in the room. All of these work on instances ofJid, except fororg.jivesoftware.smackx.muc.MultiUserChat#revokeAdmin(org.jxmpp.jid.EntityJid)(which usesEntityJid).The API ideally is consistent - even
grantAdmin()usesJid.revokeAdmin()should also useJidinstead ofEntityJid.Fixes SMACK-948.