Prevent recursive notifications #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guusdk
requested changes
Oct 26, 2022
| && isNotServerGeneratedPacket(packet); | ||
| } | ||
|
|
||
| private boolean isNotServerGeneratedPacket(Packet packet) { |
There was a problem hiding this comment.
I have two separate issues with this approach:
- I do not think this strictly identifies 'server generated' stanzas. JIDs from remote domains also match this, as do JIDs from components.
- Is the problem fixed best by ignoring everything that originates from the server? Is there a use-case where we might want to filter that content? Maybe it's better to somehow flag notifications, and then always allow those flagged messages when they are sent to users that are expected to receive them.
|
Also: changelog. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1
Doesn't attempt to filter any packets that have originated from the server (have no Node in the JID)
No tests, as the code is on the Plugin class, and the effort to set this up for unit testing would be larger that the fix. Sorry :(