Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use correct typing notation for args and kwargs #97

Merged
merged 1 commit into from
Sep 30, 2022
Merged

refactor: use correct typing notation for args and kwargs #97

merged 1 commit into from
Sep 30, 2022

Conversation

cesarcoatl
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Use correct typing notation for *args and **kwargs.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Sep 30, 2022

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 0.02 ⭐ 0.02 ⭐ 0.00
Method Length 11.49 ⭐ 11.49 ⭐ 0.00
Working memory 2.86 ⭐ 2.86 ⭐ 0.00
Quality 98.65% 98.65% 0.00%
Other metrics Before After Change
Lines 5580 5580 0
Changed files Quality Before Quality After Quality Change
src/com/inductiveautomation/factorypmi/application/script/builtin/init.py 98.83% ⭐ 98.83% ⭐ 0.00%
src/com/inductiveautomation/ignition/common/init.py 98.22% ⭐ 98.22% ⭐ 0.00%
src/com/inductiveautomation/ignition/common/alarming/init.py 99.49% ⭐ 99.49% ⭐ 0.00%
src/com/inductiveautomation/ignition/common/alarming/evaluation/init.py 98.92% ⭐ 98.92% ⭐ 0.00%
src/com/inductiveautomation/ignition/common/alarming/query/init.py 99.80% ⭐ 99.80% ⭐ 0.00%
src/com/inductiveautomation/ignition/common/browsing/init.py 97.92% ⭐ 97.92% ⭐ 0.00%
src/com/inductiveautomation/ignition/common/config/init.py 97.07% ⭐ 97.07% ⭐ 0.00%
src/com/inductiveautomation/ignition/common/gson/init.py 99.71% ⭐ 99.71% ⭐ 0.00%
src/com/inductiveautomation/ignition/common/i18n/init.py 99.53% ⭐ 99.53% ⭐ 0.00%
src/com/inductiveautomation/ignition/common/messages/init.py 97.72% ⭐ 97.72% ⭐ 0.00%
src/com/inductiveautomation/ignition/common/model/values/init.py 99.23% ⭐ 99.23% ⭐ 0.00%
src/com/inductiveautomation/ignition/common/opc/init.py 98.76% ⭐ 98.76% ⭐ 0.00%
src/com/inductiveautomation/ignition/common/script/adapters/init.py 99.16% ⭐ 99.16% ⭐ 0.00%
src/com/inductiveautomation/ignition/common/script/builtin/init.py 97.77% ⭐ 97.77% ⭐ 0.00%
src/com/inductiveautomation/ignition/common/user/init.py 97.78% ⭐ 97.78% ⭐ 0.00%
src/com/inductiveautomation/ignition/common/util/init.py 98.13% ⭐ 98.13% ⭐ 0.00%
src/com/inductiveautomation/ignition/modules/serial/scripting/init.py 96.11% ⭐ 96.11% ⭐ 0.00%
src/java/awt/init.py 97.94% ⭐ 97.94% ⭐ 0.00%
src/java/awt/image/init.py 99.00% ⭐ 99.00% ⭐ 0.00%
src/java/io/init.py 99.16% ⭐ 99.16% ⭐ 0.00%
src/java/lang/init.py 98.23% ⭐ 98.23% ⭐ 0.00%
src/java/net/init.py 99.45% ⭐ 99.45% ⭐ 0.00%
src/java/util/init.py 98.83% ⭐ 98.83% ⭐ 0.00%
src/javax/swing/init.py 96.09% ⭐ 96.09% ⭐ 0.00%
src/org/apache/commons/math3/exception/init.py 97.59% ⭐ 97.59% ⭐ 0.00%
src/org/python/core/init.py 99.18% ⭐ 99.18% ⭐ 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
src/javax/swing/init.py JOptionPane.showOptionDialog 0 ⭐ 44 ⭐ 11 😞 75.56% ⭐ Extract out complex expressions
src/javax/swing/init.py JOptionPane.showInputDialog 0 ⭐ 38 ⭐ 10 😞 78.43% ⭐ Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@cesarcoatl cesarcoatl merged commit 280fa8f into ignition-devs:main Sep 30, 2022
@cesarcoatl cesarcoatl deleted the refactor/typing-args-kwargs branch September 30, 2022 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant