fix: raise Http404 on inaccessible posts

Closes: vas3k#1152

posts/api.py

@@ -25,7 +25,7 @@ def md_show_post(request, post_type, post_slug):
     if not post.is_public:
         access_denied = check_user_permissions(request, post=post)
         if access_denied:
-            raise ApiAuthRequired()
+            raise Http404()
 
     post_markdown = f"""# {post.title}\n\n{post.text}"""
 

posts/tests/test_api.py

@@ -1,7 +1,9 @@
 from datetime import datetime
 
 from django.test import TestCase
+from django.urls import reverse
 
+from debug.helpers import HelperClient
 from posts.tests.test_views import ModelCreator
 
 
@@ -37,3 +39,23 @@ def test_content_text_is_not_none(self):
         )
         converted_post = post.to_dict()
         self.assertIsNotNone(converted_post["content_text"])
+
+    def test_404_on_hidden_post(self):
+        post = self.creator.create_post(
+            is_visible=True,
+            is_public=False,
+        )
+        client = self._authorized_client(None)
+        response = client.get(self._post_md_url(post))
+        self.assertContains(response=response, text='', status_code=404)
+
+    @staticmethod
+    def _post_md_url(post) -> str:
+        return reverse('md_show_post', args=(post.type, post.slug))
+
+    @staticmethod
+    def _authorized_client(user):
+        client = HelperClient(user)
+        if user is not None:
+            client.authorise()
+        return client

posts/tests/test_views.py

@@ -49,6 +49,15 @@ def test_show_post(self):
 
             self.assertContains(response=response, text='', status_code=200)
 
+    def test_404_on_hidden_post(self):
+        post = self.creator.create_post(
+            is_visible=True,
+            is_public=False,
+        )
+        client = self._authorized_client(None)
+        response = client.get(self._post_url(post))
+        self.assertContains(response=response, text='', status_code=404)
+
     def test_show_draft_post(self):
         '''
         Is regression test for #545.

posts/views/posts.py

@@ -33,7 +33,7 @@ def show_post(request, post_type, post_slug):
     if not post.is_public:
         access_denied = check_user_permissions(request, post=post)
         if access_denied:
-            return access_denied
+            raise Http404()
 
     # record a new view
     last_view_at = None