Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.intentdefinition files misclassified as resources. #228

Closed
nicolasrostan opened this issue Jan 9, 2023 · 3 comments
Closed

.intentdefinition files misclassified as resources. #228

nicolasrostan opened this issue Jan 9, 2023 · 3 comments

Comments

@nicolasrostan
Copy link
Contributor

Intent definition files (https://developer.apple.com/documentation/widgetkit/making-a-configurable-widget) are being classified as resources, when they should be classified as sources.

Suggested solution:
add .intentdefinition to the sources list in path_classifier
nicolasrostan added a commit to nicolasrostan/xcake that referenced this issue Jan 9, 2023
@nicolasrostan
[igor-makarov#228] fix intentdefinition classification
404effa
@nicolasrostan nicolasrostan mentioned this issue Jan 9, 2023
Merged
@CaioSym
Copy link

CaioSym commented Jan 18, 2023

Any updates on this @igor-makarov ?

igor-makarov pushed a commit that referenced this issue Jan 18, 2023
@nicolasrostan
[#228] fix intentdefinition classification (#229)
1a034c6
@igor-makarov
Copy link
Owner

Sorry for the delay! I frankly hadn't looked at it or I'd have noticed it's such a small change.

Version 0.13.0 includes your change!

@CaioSym
Copy link

CaioSym commented Jan 18, 2023

Nah. Thanks for all the good work. GH Notifications are crap 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@CaioSym @nicolasrostan @igor-makarov