Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize the repo and fix CI + PR flow #189

Merged
merged 35 commits into from
Dec 22, 2018
Merged

Modernize the repo and fix CI + PR flow #189

merged 35 commits into from
Dec 22, 2018

Conversation

igor-makarov
Copy link
Owner

@igor-makarov igor-makarov commented Dec 22, 2018 •
edited
Loading

This changeset follows the transfer of the repo to @igor-makarov, the new maintainer.
Includes:

  • Update the README.md to current maintainer info.
  • Fix Travis CI and reduce the outdated test matrix.
  • Remove Hound, as it's been providing inconsistent comments, and replace it with Rubocop on Travis.
  • Fix most Rubocop linter errors by tweaking the config and fixing remaining offences.
  • Configure new Coveralls identity along with SimpleCov for local development.
  • Make it easy to pry whenever necessary by requiring it in spec_helper.rb.

houndci-bot
houndci-bot reviewed Dec 22, 2018
View reviewed changes
spec/spec_helper.rb Show resolved Hide resolved
lib/xcake/dsl/configurable.rb Outdated Show resolved Hide resolved
fastlane-plugin-xcake/spec/spec_helper.rb Show resolved Hide resolved
Rakefile Show resolved Hide resolved
@igor-makarov igor-makarov changed the title [wip] Update everything and make it CI! Modernize the repo and fix CI Dec 22, 2018
@igor-makarov igor-makarov changed the title Modernize the repo and fix CI Modernize the repo and fix CI + PR flow Dec 22, 2018
@igor-makarov igor-makarov merged commit 90ddaf0 into master Dec 22, 2018
@igor-makarov igor-makarov deleted the new-management branch December 22, 2018 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@igor-makarov @houndci-bot