-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: filter __in #57
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #57 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 64 64
Lines 4468 4510 +42
=========================================
+ Hits 4468 4510 +42 ☔ View full report in Codecov by Sentry. |
Hey, @JakNowy, thanks for another great PR🎉! |
@JakNowy did you get a chance to take a look at this? |
Hey @igorbenav not yet, but I will definetely add some more docs and |
Added |
I'll create another issue for the missing comparison operators, we can handle it there. Thanks for the pr! |
Pull Request Template for FastCRUD
Description
This PR adds support for in_ filtering in crud methods like FastCRUD.select(item_id__in=[1,2]).
Changes
Extended parse_filters method with addtional elif op == "in", mapping to sqlalchemy/sqlmodel or() filter.
Tests
Added a test to test_parse_filters for both sqlalchemy and sqlmodel.
Checklist
Additional Notes
I was trying to acomplish something similar for or_() but it turned out to be too complex for now.