Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ignored_paths configuration and corresponding tests #96

Conversation

MikhailVerbitski
Copy link

  • Introduced a new ignored_paths configuration to allow ignoring requests based on URL path prefixes (e.g., '/admin').
  • Updated the initializer documentation with an example for configuring ignored_paths.
  • Added tests to ensure requests with matching paths are properly ignored.
  • Retained the original ignored_endpoints functionality for controller#action notation while extending flexibility with URL path-based ignoring.

- Introduced a new `ignored_paths` configuration to allow ignoring requests based on URL path prefixes (e.g., '/admin').
- Updated the initializer documentation with an example for configuring `ignored_paths`.
- Added tests to ensure requests with matching paths are properly ignored.
- Retained the original `ignored_endpoints` functionality for controller#action notation while extending flexibility with URL path-based ignoring.
@@ -21,6 +21,10 @@
# You can ignore endpoints with Rails standard notation controller#action
# config.ignored_endpoints = ['HomeController#contact']

# You can ignore request paths by specifying the beginning of the path.
# For example, all routes starting with '/admin' can be ignored:
# config.ignored_paths = ['/admin']
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also include it in the readme

the rest of the changes are fine 👍

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@igorkasyanchuk igorkasyanchuk merged commit 3f68a55 into igorkasyanchuk:master Oct 25, 2024
4 checks passed
@igorkasyanchuk
Copy link
Owner

@MikhailVerbitski new version was released. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants