-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #293
base: master
Are you sure you want to change the base?
Update README.md #293
Conversation
add a clarification for igorshubovych#292
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, don't understand this?
README.md
Outdated
@@ -57,7 +57,7 @@ Quoting the glob like `--ignore '*.md'` passes it through unexpanded and ignores | |||
|
|||
#### Globbing examples | |||
|
|||
To lint all Markdown files in a Node.js project (excluding dependencies), the following commands might be used: | |||
To lint all Markdown files recursively in a Node.js project (excluding dependencies), `*/**.md` wildcard comes in handy. The following commands might be used: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think */**.md
is what's intended? And **/*.md
is already shown on the next two lines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DavidAnson my intention was to add mention the explanation of this wildcard that is used in the code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think lines 62 and 64 already show the preferred syntax?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DavidAnson yeah, I agree it shows the syntax.
So I didn't change the syntax, but rather add a precise clarification as a word explanation about the syntax, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DavidAnson what do you think of these changes? Is there anything that concerns you that we can discuss?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DavidAnson If you still think this PR has no sense, and it's not discussable please let me know - I will close it :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please read the comment you link to again, it does not say what you think it says.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DavidAnson You're missing the first part of the folder wildcard if you want it have a recursive glob "**/*.md"
? taken from #292 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The existing examples and Nick's comment use the syntax **/*.md
which is the conventional way to match all files with a particular extension. Your proposed change uses the syntax */**.md
which means something different.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DavidAnson ah, sorry, it was a typo. I didn't notice it. I thought to add */**.md
, but mistakenly I added **/*.md
. Thank you for your look, I updated the PR accordingly
Please, let me know if it works for you :)
fix typo
add a clarification for #292