Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Link Fortran runtime on Windows as needed by arpack. #1215

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

kalibera
Copy link
Contributor

@kalibera kalibera commented Feb 7, 2024

Fortran libraries (Fortran runtime) is needed e.g. by arpack. This change is to fix building on LLVM/aarch64.

Copy link
Contributor

aviator-app bot commented Feb 7, 2024

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged using Aviator.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

Copy link
Contributor

@krlmlr krlmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Do we need the same change in Makevars.win ?

@krlmlr krlmlr changed the title Link Fortran runtime on Windows as needed by arpack. fix: Link Fortran runtime on Windows as needed by arpack. Feb 8, 2024
@aviator-app aviator-app bot merged commit b0df457 into igraph:main Feb 8, 2024
14 checks passed
@kalibera
Copy link
Contributor Author

kalibera commented Feb 8, 2024

Thanks. Do we need the same change in Makevars.win ?

It would be probably cleaner to do so, because Fortran runtime is used. But you probably don't need it, certainly not for aarch64.

I am not sure if you need Makevars.win at all, maybe you could delete it and rename the current Makevars.ucrt to Makevars.win. That depends on how old versions of R you want to support (on CRAN).

Makevars.ucrt is used by R >= 4.2.0, when it exists. When it doesn't exist, R >= 4.2.0 uses Makevars.win as well as the older versions of R do (details are in Writing R Extensions).

At least with R >= 4.2.0 (and so Rtools >= 42), you don't even need to specify "-I" options for LIB_XML, GLPK_HOME, LIB_GMP, the R_TOOLS_SOFT directory is by default made available by the toolchain. So you might need a distinct Makevars.win only if you wanted to support R < 4.2 (with Rtools < 42).

@krlmlr
Copy link
Contributor

krlmlr commented Feb 8, 2024

Thanks for your input. I guess I'll go with "never touch a running system" with this respect, and adapt as needed on users's request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants