Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update allcontributors table #1552

Merged
merged 1 commit into from
Oct 14, 2024
Merged

docs: update allcontributors table #1552

merged 1 commit into from
Oct 14, 2024

Conversation

maelle
Copy link
Contributor

@maelle maelle commented Oct 11, 2024

Fix #1239

But I think not all contributors are detected.

Copy link
Contributor

aviator-app bot commented Oct 11, 2024

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged using Aviator.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@maelle maelle marked this pull request as draft October 11, 2024 10:14
@mpadge
Copy link

mpadge commented Oct 11, 2024

@maelle You were right. ropensci/allcontributors#42 has fixed the issue. thanks 👍 (Interestingly, there are 58 code contributors at present, yet GitHub shows 59, even though one of these logins is no longer valid. allcontributors removes that one, yet GitHub retains it. Curious!)

@maelle
Copy link
Contributor Author

maelle commented Oct 11, 2024

@mpadge I'm confused

allcontributors::get_contributors("igraph", "rigraph")
#> ★  Extracting code contributors
#> ✔ Extracted code contributors
#> ★  Extracting github issue contributors
#> ✔ Extracted github issue contributors
#> ★  Checking GitHub URLs
#> ✔ Checked GitHub URLs
#>          logins contributions
#> 1   gaborcsardi          1504
#> 2        krlmlr          1012
#> 3        maelle           865
#> 4        ntamas           508
#> 5      szhorvat           281
#> 6    Antonov548           181
#> 7      adalisan            16
#> 8      dmurdoch             6
#> 9       olivroy             3
#> 10       hadley             2
#> 11     clpippel             2
#> 12   wael-sadek             2
#> 13      peranti             1
#> 14       raulzr             1
#> 15       zeehio             1
#> 16         smoe             1
#> 17        mirca             1
#> 18     a-lambda             1
#> 19     person-c             1
#> 20     etheleon             1
#> 21       stnava             1
#> 22     kasterma             1
#> 23     clhunsen             1
#> 24        qsz13             1
#> 25      QuLogic             1
#> 26 Hosseinazari             1
#> 27       jeroen             1
#> 28      reuning             1
#> 29   MajoroMask             1
#>                                                   avatar type
#> 1     https://avatars.githubusercontent.com/u/660288?v=4 code
#> 2    https://avatars.githubusercontent.com/u/1741643?v=4 code
#> 3    https://avatars.githubusercontent.com/u/8360597?v=4 code
#> 4     https://avatars.githubusercontent.com/u/195637?v=4 code
#> 5    https://avatars.githubusercontent.com/u/1212871?v=4 code
#> 6   https://avatars.githubusercontent.com/u/22891541?v=4 code
#> 7    https://avatars.githubusercontent.com/u/1790714?v=4 code
#> 8    https://avatars.githubusercontent.com/u/1935680?v=4 code
#> 9   https://avatars.githubusercontent.com/u/52606734?v=4 code
#> 10      https://avatars.githubusercontent.com/u/4196?v=4 code
#> 11   https://avatars.githubusercontent.com/u/9609214?v=4 code
#> 12  https://avatars.githubusercontent.com/u/42678896?v=4 code
#> 13   https://avatars.githubusercontent.com/u/9472741?v=4 code
#> 14  https://avatars.githubusercontent.com/u/13007941?v=4 code
#> 15     https://avatars.githubusercontent.com/u/75441?v=4 code
#> 16    https://avatars.githubusercontent.com/u/207407?v=4 code
#> 17  https://avatars.githubusercontent.com/u/13077051?v=4 code
#> 18 https://avatars.githubusercontent.com/u/155024809?v=4 code
#> 19  https://avatars.githubusercontent.com/u/93318795?v=4 code
#> 20   https://avatars.githubusercontent.com/u/2868858?v=4 code
#> 21    https://avatars.githubusercontent.com/u/324222?v=4 code
#> 22    https://avatars.githubusercontent.com/u/421437?v=4 code
#> 23   https://avatars.githubusercontent.com/u/2649820?v=4 code
#> 24   https://avatars.githubusercontent.com/u/4075761?v=4 code
#> 25    https://avatars.githubusercontent.com/u/302469?v=4 code
#> 26    https://avatars.githubusercontent.com/u/971459?v=4 code
#> 27    https://avatars.githubusercontent.com/u/216319?v=4 code
#> 28   https://avatars.githubusercontent.com/u/6343832?v=4 code
#> 29  https://avatars.githubusercontent.com/u/19700954?v=4 code

Created on 2024-10-11 with reprex v2.1.0

@maelle
Copy link
Contributor Author

maelle commented Oct 11, 2024

So I get only code contributors and not even enough of them.

@maelle
Copy link
Contributor Author

maelle commented Oct 11, 2024

@mpadge the problem is with the URL checking, I'll turn it off for now.

@maelle maelle marked this pull request as ready for review October 14, 2024 12:47
@aviator-app aviator-app bot merged commit b432688 into main Oct 14, 2024
12 checks passed
@aviator-app aviator-app bot deleted the allcontributors branch October 14, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update allcontributors table in README
2 participants