test: Test handling of "return.vs.es"
in several functions
#1610
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completes the fix of #1605 and adds tests.
Since the tests of
neighbors()
were based onas_adj_list()
, I have extended the test of the latter to also run withreturn.vs.es = FALSE
. I extended the tests ofneighbors()
and added tests foradjacent_vertices()
andincident_edges()
.I found another small issue related to this one that I think is a mistake. But I am not entirely sure that it is, so I would like to have confirmation before I fix it:
as_adj_edge_list()
does not respect the settingreturn.vs.es
and always returnsigraph.es
objects. Could someone please confirm that this is indeed not the expected behaviour. I could then fix this and update the pull request. Or should I open a new issue for this?