Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support neovim in vimgolf cli #246

Merged
merged 2 commits into from
Jun 1, 2018
Merged

Support neovim in vimgolf cli #246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f5a068e
Support neovim in vimgolf cli
mayanksuman May 30, 2018
00d51a6
Removed rvm<2.0 for compiling cli component
mayanksuman May 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@ matrix:
- rvm: 2.4.1 # Test web AND cli with specific version
gemfile: Gemfile
# Otherwise test only the cli
- rvm: 1.9
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any particular reason why you removed this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because ruby 1.9 is no more supported https://www.ruby-lang.org/en/news/2015/02/23/support-for-ruby-1-9-3-has-ended/

I m pretty sur it is because since your last merge (upgrade gem) the 1.9 test stopped working because of gem incompatible with r 1.9

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough :-)

gemfile: lib/vimgolf/Gemfile
- rvm: 2.3
gemfile: lib/vimgolf/Gemfile

Expand Down
5 changes: 4 additions & 1 deletion lib/vimgolf/lib/vimgolf/cli.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,10 @@ def play(challenge)
# -u vimrc - load vimgolf .vimrc to level the playing field
# -U NONE - don't load .gvimrc
# -W logfile - keylog file (overwrites if already exists)
vimcmd = GOLFVIM.shellsplit + %W{-Z -n --noplugin --nofork -i NONE +0 -u #{challenge.vimrc_path} -U NONE -W #{challenge.log_path} #{challenge.work_path}}
vimcmd = GOLFVIM.shellsplit + %W{-Z -n --noplugin -i NONE +0 -u #{challenge.vimrc_path} -U NONE -W #{challenge.log_path} #{challenge.work_path}}
if GOLFVIM == "gvim"
vimcmd += %W{ --nofork}
end
debug(vimcmd)
system(*vimcmd) # assembled as an array, bypasses the shell

Expand Down