Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read count from cram popup is sometimes wrong #1323

Closed
scalavision opened this issue May 5, 2021 · 5 comments
Closed

read count from cram popup is sometimes wrong #1323

scalavision opened this issue May 5, 2021 · 5 comments

Comments

@scalavision
Copy link

scalavision commented May 5, 2021

Sometimes the read count is a few counts off for cram files. It is shown in the image below, which is from HG002 sample in opened in https://allel.es/, updated with the newest version of igv, 2.8.1. It usually diverges between 1 and 5-6 counts, and it seems to consistently be increased. It might have improved a bit from 2.7.9 which we used when we first encountered this, but this is not confirmed in any way.

The bam file was converted to cram using samtools. When opening the tracks in java version of igv, the read count shows the same for both bam and cram, and it is equal to the bam count in igv.js.

I have extracted the example region from the original bam and cram in example01.tar.gz. It shows the same count error.

Let me know if you need more information to properly investigate this.

read_count_wrong_igvjs

example01.tar.gz

@jrobinso
Copy link
Contributor

jrobinso commented Jul 17, 2021

Apologies for the delay looking into these. I can't reproduce this with the example data you provided, the config object for my test case is below. If you can modify the config to reproduce the issue, or give me other instructions, I will investigate further.

        {
            genome: "hg19",
            locus: "1:161,518,391-161,518,554",
            tracks:
                [{
                    type: 'alignment',
                    format: 'bam',
                    url: 'example01/example01.bam',
                    indexURL: 'example01/example01.bam.bai',
                    name: 'BAM',
                    height: 300
                },
                    {
                        type: 'alignment',
                        format: 'cram',
                        url: 'example01/example01.cram',
                        indexURL: 'example01/example01.cram.crai',
                        name: 'CRAM',
                        height: 300
                    }
                ]
        }

@scalavision
Copy link
Author

Thanks for looking into this. I am on vacation but will look into it again when I am back, in a couple of weeks. You can close this if you want, and I can reopen it, if I still have problems.

@jrobinso
Copy link
Contributor

@scalavision Actually on closer inspection I found the issue. Alignments marked "duplicate" are being filtered from BAM sources, but not from CRAM sources. I will correct this for the next release (they should be filtered from both).

@scalavision
Copy link
Author

That is great! Looking forward to the fix :-)

@jrobinso
Copy link
Contributor

This should be fixed now, igv.js version 2.9.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants