Image support #372
Closed
Image support #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danschwarz
force-pushed
the
images
branch
2 times, most recently
from
8c00220 to
a620588
Compare
ihabunek
force-pushed
the
images
branch
2 times, most recently
from
02e288e to
4167933
Compare
|
I'll periodically rebase this on master to avoid getting conflicted again. |
|
@danschwarz Doing some work on this branch so I'll need to rebase again. Just FYI. Sorry if i break your stuff. I'm trying to make it so that image support is optional so TUI works without term_image installed. |
|
Ok, I'm fine with anything that gets image support into the master branch- I'll check for any breakage. |
Adding missing comma in setup
|
See #389 |
--image-format='kitty'|'iterm'|'block' (default is block) autodetection was causing intermittent phantom character output to the terminal in some configurations, generally over SSH connections. Switching to a command line option eliminates the problematic autodetection code. As a side effect, EmojiText widget had to be removed.
All image code is now a soft dependency. If the term-image and/or pillow libraries are not loaded, the tui will work fine without displaying images. Note that tests/test_utils.py still has a dependency on pillow due to its use of Image for tsting the LRUCache.
|
Merged manually, thanks for this. Sorry for dragging my feet on this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased and squashed #319 since its history was getting very messy.