added --color flag to force color even if stdout is a tty #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I see I'd say this implementation is ok. Thanks a lot ! |
|
Thanks, but I'm in the middle of the Click rewrite so it will be handled there. See #428, work in progress. |
|
On December 7, 2023 9:40:10 AM GMT+01:00, Ivan Habunek ***@***.***> wrote:
Thanks, but I'm in the middle of the Click rewrite so it will be handled there. See #428, work in progress.
Do you accept pull requests for the 'click' branch ?
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
|
|
The code there is very much in flux so i would prefer if you waited until it is merged. What did you have in mind?
…-- Ivan
On Thu, 7 Dec 2023, at 11:28, Sandro Santilli wrote:
On December 7, 2023 9:40:10 AM GMT+01:00, Ivan Habunek ***@***.***> wrote:
>Thanks, but I'm in the middle of the Click rewrite so it will be handled there. See #428, work in progress.
>
Do you accept pull requests for the 'click' branch ?
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
—
Reply to this email directly, view it on GitHub <#439 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADVWWS6467ZTGPD4ID4O7LYIGK53AVCNFSM6AAAAABAKEMCDKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBVGA4DINBQG4>.
You are receiving this because your review was requested.Message ID: ***@***.***>
|
|
What did you have in mind?
Nothing in particular, just this PR itself
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option was inspired by @strk comment:
#422 (comment)
Now there is a
--coloroption that works exactly like (but opposite to) the--no-coloroption.There are other ways to implement this, possibly by replacing
--no-colorwith something like--colorwith values likeyes,no,auto(auto being default and what the app currently does if no flag passed).If you'd rather see the flag implemented that way, I can change the code. Otherwise, this is good to go and allows things like
toot timeline --count 20 --color | less -Rto display timeline output, properly paged, in color.