Added full discography download #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evolution0
reviewed
Jun 20, 2023
bandcamp_dl/__main__.py
Outdated
| @@ -84,6 +84,9 @@ def main(): | |||
| urls = Bandcamp.generate_album_url(arguments['--artist'], arguments['--track'], "track") | |||
| elif arguments['--artist']: | |||
| urls = Bandcamp.get_full_discography(arguments['--artist'], "music") | |||
| print(f"{len(urls)} albums/tracks have been found:") | |||
There was a problem hiding this comment.
Other than this print I don't really have an issue with the PR. I just don't see a reason to clutter the terminal with anything more than the existing progress bar especially considering its not really a value add to print the urls.
If you want to dump them in debug that is fine though.
There was a problem hiding this comment.
Alright, I decided to remove it. It's already committed.
|
Awesome! Now how do I input the command arguments correctly? |
Should just need to pass the discography page as the URL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes Issue #150. It downloads the full discography, gives a list of URLs it will download, and will download both albums and tracks from an artist's music page.