Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Scenario Editor] Prohibit the positioning of the ultimate artifact near an edge of the adventure map with the 9 squares rule of the original game #8896

Open
2 tasks done
LeHerosInconnu opened this issue Jun 29, 2024 · 5 comments
Labels
awaiting feedback Feedback was requested from the issue opener bug Something doesn't work editor Map editor related stuff
Milestone

Comments

@LeHerosInconnu
Copy link

Preliminary checks

Platform

Windows

Describe the bug

In fheroes2, positioning the ultimate artifact near an edge of the adventure map should not be allowed.

In original game:

9 squares rule 01

In fheroes2:

9 squares rule 10 001

9 squares rule 10 002

9 squares rule 10 003

Also, it shouldn't be possible to save a scenario if there isn't a location available where to automatically place the ultimate artifact (in case the scenario creator doesn't manually position the ultimate artifact).
A message should be displayed to indicate this to the scenario creator.

Save file

Here is the test scenario file:
Ultitop.zip

Additional info

Related closed issues: #1944, #1536.

@LeHerosInconnu LeHerosInconnu added the bug Something doesn't work label Jun 29, 2024
@oleg-derevenetz oleg-derevenetz added the editor Map editor related stuff label Jul 5, 2024
@oleg-derevenetz oleg-derevenetz added this to the 1.1.2 milestone Jul 5, 2024
@ihhub
Copy link
Owner

ihhub commented Jul 26, 2024

Hi @LeHerosInconnu , besides the limitation of the original Editor what's the real reason to do so? I see this as imposing unnecessary limitation on map makers.

@ihhub ihhub added the awaiting feedback Feedback was requested from the issue opener label Jul 26, 2024
@oleg-derevenetz
Copy link
Collaborator

besides the limitation of the original Editor what's the real reason to do so? I see this as imposing unnecessary limitation on map makers.

I believe if UA will be buried somewhere near the map corner, it will be too clearly visible on the Monolith's relief image, and it may be too easy to find the appropriate place on the adventure map.

@LeHerosInconnu
Copy link
Author

Hello @ihhub,

Hi @LeHerosInconnu , besides the limitation of the original Editor what's the real reason to do so? I see this as imposing unnecessary limitation on map makers.

In the original game, the rule of 9 squares is there to avoid problems with the edges of the map (say the Ultimate Artifact is positioned right in the place of the hero in the example).
First an aesthetic problem and the recognition of the map around the position of the Ultimate Artifact.
It is not very nice to display the edge of the map in the puzzle screen.
It is difficult to recognize the position on the map if only the revealed puzzle parts are located in the edge space.
Then a problem of "cheating".
It is easier to locate the position of the Ultimate Artifact if part of the frame is displayed in the puzzle screen.

In original game:

Ultime Artifact view puzzle H2 10

Now the scenario creator really has to intentionally create a scenario without the ability to place the Utimate Artifact with the 9 squares rule.
A scenario with only land located around the map within the limit of 9 squares.
I have never seen such a map.
To avoid this, a message should appear in the scenario editor when this happens.

Originally posted by @LeHerosInconnu in #1536 (comment)

@ihhub
Copy link
Owner

ihhub commented Jul 27, 2024

Hi @oleg-derevenetz and @LeHerosInconnu , I see that some map makers explicitly want to put an ultimate artifact in a corner of a map. This is a valid case. Random ultimate artifact generation follows the mentioned rule.

@LeHerosInconnu
Copy link
Author

Hello @ihhub,

Hi @oleg-derevenetz and @LeHerosInconnu , I see that some map makers explicitly want to put an ultimate artifact in a corner of a map. This is a valid case. Random ultimate artifact generation follows the mentioned rule.

I've given my opinion on the aesthetic, impractical and "cheating" aspects of the thing, and I don't really see the point of positioning the ultimate artifact near the edge of the adventure map.
Also, I've never read any complaints from scenario creators since the year the game was released about this limitation on positioning the ultimate artifact.

For me, this type of screen is not desirable:
In fheroes2:

Ultimate 001

Ultimate 002

Ultimate 003

Now do what you think is the best for the game.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting feedback Feedback was requested from the issue opener bug Something doesn't work editor Map editor related stuff
Projects
None yet
Development

No branches or pull requests

3 participants