Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View Puzzle screen, Ultimate Artifact, the rule of 9 squares of the original game should be respected #1944

Closed
LeHerosInconnu opened this issue Oct 10, 2020 · 2 comments · Fixed by #2989
Assignees
Labels
bug Something doesn't work logic Things related to game logic
Milestone

Comments

@LeHerosInconnu
Copy link

In fheroes2, maps without a predetermined position of the Ultimate Artifact by the author of the scenario (automatic random placement of the position of the Ultimate Artifact), must follow the rules of the 9 squares of the original game (the Ultimate Artifact is positioned at a distance at least 9 squares from the edges of the map) to avoid problems with the edges of the map described in this thread: #1536.

Here is a screenshot of the puzzle with the position of the Ultimate Artifact too close to the edge of the map.
Part of the bottom edge of the map is visible.
In this scenario the location of the Ultimate Artifact is randomly placed automatically.

In fheroes2:

Puzzle 9 squares rule 01

Here is the save file:
Puzzle near edge 01.zip

@ihhub ihhub added logic Things related to game logic bug Something doesn't work Hacktoberfest labels Oct 12, 2020
@ihhub ihhub added this to the 0.9 milestone Oct 12, 2020
@Branikolog
Copy link
Collaborator

Hi, @LeHerosInconnu
I also find a weird UA location case on a map, I've created.
The only free space is placed too close to world map edge. And the game decided to place UA over the existing hole on a distant island.
image
image
The strange thing is that this place is always the same on this map...
Map_0368.zip
I also have a question for you.
Here, we have both cases, where "9 square rule" and "auto-placing of UA avoid certain areas" (#2317) are broken.
How should be artifact be placed here? On the only free space, but close to an edge? Or on any place, distant from the edges enough, but taken with object, like hole, river etc?

@LeHerosInconnu
Copy link
Author

Hello @Branikolog,

Hi, @LeHerosInconnu
I also find a weird UA location case on a map, I've created.
The only free space is placed too close to world map edge. And the game decided to place UA over the existing hole on a distant island.
The strange thing is that this place is always the same on this map...

Apparently, fheroes2 always chooses the first available spot relative to the map coordinates (0,0 in the upper left corner).
It should not be the case.

I also have a question for you.
Here, we have both cases, where "9 square rule" and "auto-placing of UA avoid certain areas" (#2317) are broken.
How should be artifact be placed here? On the only free space, but close to an edge? Or on any place, distant from the edges enough, but taken with object, like hole, river etc?

On any place, distant from the edges enough.
River first (or other objects of the same category (decorations but accessible)), digging hole next (to avoid misleading the player as much as possible), free space behind object last (behind a mountain, etc.).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something doesn't work logic Things related to game logic
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants