Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adventure map, faulty artifact being picked up causes forest to disappear temporary #8505

Closed
2 tasks done
Branikolog opened this issue Mar 20, 2024 · 3 comments · Fixed by #8949
Closed
2 tasks done

Adventure map, faulty artifact being picked up causes forest to disappear temporary #8505

Branikolog opened this issue Mar 20, 2024 · 3 comments · Fixed by #8949
Assignees
@ihhub
Labels
bug Something doesn't work logic Things related to game logic ui UI/GUI related stuff
Milestone
1.1.2

Comments

@Branikolog
Copy link
Collaborator

Preliminary checks

Platform

Windows

Describe the bug

The artifact my hero is picking does not correspond the sprite we watch on the screen. Picking it up also causes forest to disappear during fading animation.

2024-03-21.00-30-01.mov

I've checked on two separate games - there's always a magic ring. But this could be a coincidence though.

Save file

Lost_Relic_artifact issue.zip

Additional info

No response
@Branikolog Branikolog added bug Something doesn't work ui UI/GUI related stuff logic Things related to game logic labels Mar 20, 2024
@Branikolog Branikolog added this to the 1.1.0 milestone Mar 20, 2024
@ihhub ihhub self-assigned this Mar 21, 2024
@ihhub ihhub modified the milestones: 1.1.0, 1.1.1 Mar 21, 2024
@ihhub
Copy link
Owner

ihhub commented Mar 23, 2024

This is the problem of object removal logic.

@Branikolog
Copy link
Collaborator Author

Actually, this map (Lost Relic) has multiple places, where artifacts were placed on improper places. If I'm not mistaken we were already fixed some issue on this map: an artifact was placed on an improper cell somewhere in swamps.

@ihhub
Copy link
Owner

ihhub commented Apr 5, 2024

As expected this is due to object positioning on this tile:

******* Tile info *******
Tile index      : 1502, point: (62, 20)
MP2 object type : 169 (Artifact)
UID             : 1181
ICN object type : 43 (TREFIR.ICN)
image index     : 22
layer type      : 0 - Object layer
is shadow       : no
region          : 4
ground          : Grass (isRoad: 0)
ground img index: 72, image flags: 0
passable from   : center, top, top-right, right, bottom-right, bottom, bottom-left, left, top-left
metadata value 1: 11
metadata value 2: 0
metadata value 3: 0
--------- Level 1 --------
UID             : 2071
ICN object type : 11 (OBJNARTI.ICN)
image index     : 105
layer type      : 0 - Object layer
is shadow       : no
--- Extra information ---
*************************

@ihhub ihhub mentioned this issue Jul 10, 2024
Merged
@Districh-ru Districh-ru mentioned this issue Jul 10, 2024
Merged
@ihhub ihhub modified the milestones: 1.1.1, 1.1.2 Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ihhub ihhub

Labels
bug Something doesn't work logic Things related to game logic ui UI/GUI related stuff
Projects
None yet
Milestone
1.1.2
2 participants
@ihhub @Branikolog