-
-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix object picking up animation, fix object remove from map and fix restoration of the object type for the tile #8949
Conversation
3ea19f7
to
ba65a24
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (1/1)
This reverts commit ca44335.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Districh-ru I just left one question, could you please take a look when you have time?
Hi @Districh-ru , please resolve merge conflicts here. |
Done! |
@Districh-ru , thank you so much for these changes! |
close #8505
This PR also fixes:
This PR affects all objects remove from the map including the move of the boat using Summon Boat.
Tile object type update:
fheroes2.2024-07-13.07-38-02-610.mp4
fheroes2.2024-07-13.07-38-35-565.mp4
Radar update:
fheroes2.2024-07-13.20-11-06-631.mp4
fheroes2.2024-07-13.20-10-04-690.mp4